[PATCH] D106053: [CodeGen] Remove pending AssertZext AssertSext in promoting FP_TO_INT

Thu Jul 15 20:08:00 PDT 2021

craig.topper added a comment.

In D106053#2882146 <https://reviews.llvm.org/D106053#2882146>, @xiangzhangllvm wrote:

> In D106053#2882145 <https://reviews.llvm.org/D106053#2882145>, @craig.topper wrote:
>
>> I'm confused. The AssertZext gets inserted by LegalizeIntegerTypes.cpp for this test case when the 8xi8 fptoui becomes an 8xi16 fptosi. LegalizeVectorOps inserts an AssertSext later when the v8i16 gets promoted to v8i32. This patch only gets rid of the AssertSext.
>
> Because I am happen see your change about adding AssertZext  at https://reviews.llvm.org/D40591, let me recheck other adding AssertZext at LegalizeIntegerTypes.cpp. Thanks for your remind!

The same code also exists in X86TargetLowering::ReplaceNodeResults.

My confusion is that at multiple points in this discussion you mentioned AssertZext being what's causing the problem, but this patch doesn't affected the AssertZext in the test.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106053/new/

https://reviews.llvm.org/D106053