[PATCH] D106091: [PowerPC] Improve error message on MASSV pass

[Bardia Mahjour via Phabricator via llvm-commits]

bmahjour added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCLowerMASSVEntries.cpp:86
+  report_fatal_error(
+      "-vector-library=MASSV option is supported only on Power8 and Power9 "
+      "subtargets when vectorization is not disabled.");
----------------
masoud.ataei wrote:
> bmahjour wrote:
> > what about Power 10? should it say "Power8 and above" or "Power8 or later"?
> Currently there is no Power10 specific entry on Linux MASS library (there are on AIX). So, if you use -mcpu=pwr10 you are actually getting P9 specific functions (like `__xl_expd2_P9`). 
> 
> Do you still think the message should say "Power8 and above"?
Sure, but MASSV is still supported on P10. The fact that we resolve to p9 entries in some cases is an implementation detail that is not relevant to the purpose of this message. I'd prefer "Power8 and later".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106091/new/

https://reviews.llvm.org/D106091