[PATCH] D106091: [PowerPC] Improve error message on MASSV pass

Masoud Ataei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 15 13:55:05 PDT 2021


masoud.ataei added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCLowerMASSVEntries.cpp:86
+  report_fatal_error(
+      "-vector-library=MASSV option is supported only on Power8 and Power9 "
+      "subtargets when vectorization is not disabled.");
----------------
bmahjour wrote:
> what about Power 10? should it say "Power8 and above" or "Power8 or later"?
Currently there is no Power10 specific entry on Linux MASS library (there are on AIX). So, if you use -mcpu=pwr10 you are actually getting P9 specific functions (like `__xl_expd2_P9`). 

Do you still think the message should say "Power8 and above"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106091/new/

https://reviews.llvm.org/D106091



More information about the llvm-commits mailing list