[PATCH] D105578: utils: add a revert checker

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv marked an inline comment as done.
george.burgess.iv added inline comments.


================
Comment at: llvm/utils/revert_checker.py:183
+  intermediate_commits = set(_shas_between(git_dir, across_sha, root_sha))
+  assert across_ref not in intermediate_commits
+
----------------
probinson wrote:
> Should this be `assert across_sha` instead of `assert across_ref` ? The ref could be spelled many ways, the sha is the canonical form and looks like what `intermediate_commits` should contain.
yeah, definite typo on my end. thanks for catching this! fixed in 3a7ca4cad4dd42120ea39b919f45a166e85d54a8


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105578/new/

https://reviews.llvm.org/D105578