[PATCH] D105578: utils: add a revert checker
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 14 09:29:34 PDT 2021
probinson added inline comments.
================
Comment at: llvm/utils/revert_checker.py:183
+ intermediate_commits = set(_shas_between(git_dir, across_sha, root_sha))
+ assert across_ref not in intermediate_commits
+
----------------
Should this be `assert across_sha` instead of `assert across_ref` ? The ref could be spelled many ways, the sha is the canonical form and looks like what `intermediate_commits` should contain.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105578/new/
https://reviews.llvm.org/D105578
More information about the llvm-commits
mailing list