[PATCH] D105996: [AArch64] Enable Upper bound unrolling universally

[JinGu Kang via Phabricator via llvm-commits]

jaykang10 added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1571
 
+  // Enable Upper bound unrolling universally, not dependant upon the conditions
+  // below.
----------------
SjoerdMeijer wrote:
> This is vague and without the context of this patch not so informative:
> 
>   not dependant upon the conditions below.
> 
> I'd say just get rid of this part.
Yep, let me remove it.


================
Comment at: llvm/test/Transforms/LoopUnroll/AArch64/unroll-upperbound.ll:42
+for.body.if.end6_crit_edge:                       ; preds = %for.body
+  unreachable
+
----------------
dmgreen wrote:
> Does the test need an unreachable in it? They (and undef) can make tests less reliable in the long run, as other code changes in llvm.
Sorry, let me remove it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105996/new/

https://reviews.llvm.org/D105996