[PATCH] D105996: [AArch64] Enable Upper bound unrolling universally

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

The perf data looks a bit thin, and I guess this is for 1 cpu, the N1? Not sure if we need some more data (and different core) to confirm this is a good thing? Or do we think this is enough?



================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1571
 
+  // Enable Upper bound unrolling universally, not dependant upon the conditions
+  // below.
----------------
This is vague and without the context of this patch not so informative:

  not dependant upon the conditions below.

I'd say just get rid of this part.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105996/new/

https://reviews.llvm.org/D105996