[PATCH] D105925: [TableGen] Warn when patterns are ignored due to impossible types

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 14 09:47:42 PDT 2021


tlively added a comment.

Is there a way we could make this behavior more specifically targeted to when the typing issue involves an HW Mode? I've never used an HW Mode (although perhaps I should), but I've had my patterns silently ignored multiple times now and it is always a painful debugging experience. Most recently was when I wrote something like this:

  def load8_lane :
    PatFrag<(ops node:$ptr, node:$vec, node:$idx),
            (vector_insert $vec, (extloadi8 $ptr), $idx)>;

The pattern that used this fragment was silently dropped until I fixed it to be

  def load8_lane :
    PatFrag<(ops node:$ptr, node:$vec, node:$idx),
            (vector_insert $vec, (i32 (extloadi8 $ptr)), $idx)>;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105925/new/

https://reviews.llvm.org/D105925



More information about the llvm-commits mailing list