[PATCH] D105967: [TableGen] Allow isAllocatable inheritence from any superclass

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 14 09:08:50 PDT 2021


kparzysz added a comment.

I think it's ok, but it makes me wonder about the other properties.  If this one can vary depending on the topological ordering, can `VTs` or `CopyCost` (for example) change too?  Logically, `VTs` should be the intersection of `VTs` over all super classes, other properties may need different treatment.



================
Comment at: llvm/utils/TableGen/CodeGenRegisters.cpp:836
   CopyCost = Super.CopyCost;
   Allocatable = Super.Allocatable;
+  if (!Allocatable) {
----------------
You could just use `any_of` for the set of super classes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105967/new/

https://reviews.llvm.org/D105967



More information about the llvm-commits mailing list