[PATCH] D105700: [LoopSimplify] Convert loop with multiple latches to nested loop using dominator tree

Wed Jul 14 01:37:59 PDT 2021

jaykang10 added a comment.

In D105700#2875230 <https://reviews.llvm.org/D105700#2875230>, @efriedma wrote:

>> As you mentioned, the existing analyses could be failed with the cascaded phi nodes from outer loop. I was able to see a test in which CanProveNotTakenFirstIteration is failed with LICM pass.
>
> Right, that's the sort of thing I'm worried about.  Which is why I don't think it makes sense to separate out nested loops unless we have some heuristic that indicates it's actually profitable, as opposed to just legal.

Thanks for the suggestion. Let me check the tests and try to find some heuristics that indicates it's actually profitable.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105700/new/

https://reviews.llvm.org/D105700