[PATCH] D105700: [LoopSimplify] Convert loop with multiple latches to nested loop using dominator tree

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 13 12:50:41 PDT 2021


efriedma added a comment.

> As you mentioned, the existing analyses could be failed with the cascaded phi nodes from outer loop. I was able to see a test in which CanProveNotTakenFirstIteration is failed with LICM pass.

Right, that's the sort of thing I'm worried about.  Which is why I don't think it makes sense to separate out nested loops unless we have some heuristic that indicates it's actually profitable, as opposed to just legal.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105700/new/

https://reviews.llvm.org/D105700



More information about the llvm-commits mailing list