[PATCH] D105842: [WebAssembly] Remove datalayout strings from llc tests
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 13 23:10:51 PDT 2021
aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.
I think that makes sense. Currently it looks if the data layout string is missing we have the default here: https://github.com/llvm/llvm-project/blob/dfd9808b6cea59ff075498ee7e6e57f2b5b3a798/llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp#L125-L131
But because this is from `WebAssemblyTargetMachine`, this only works for llc and not opt. I think we need to keep opt strings but maybe not llc then.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105842/new/
https://reviews.llvm.org/D105842
More information about the llvm-commits
mailing list