[PATCH] D105842: [WebAssembly] Remove datalayout strings from llc tests

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 12 15:19:27 PDT 2021


sbc100 added a comment.

In D105842#2872408 <https://reviews.llvm.org/D105842#2872408>, @aheejin wrote:

> Also I’m not sure if the data layout doesn’t really matter for llc tests, becuse llc also runs some IR passes. For example, WasmEHPrepare and LowerEmscriptenEHSjLj passes both run within llc and IIRC at least LowerEmscripten~ pass uses datalayout.

Surely we always want to let llvm set the data layout based on the triple though don't we?  Does opt not do this too?  What data layout other than default one for the given triple could it rationally select?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105842/new/

https://reviews.llvm.org/D105842



More information about the llvm-commits mailing list