[PATCH] D105871: Followup to D99355: implementation of sdag support for vp load/store/gather/scatter.

[Simon Moll via Phabricator via llvm-commits]

simoll added a comment.

The existing masked/gather/scatter SDNodes have seen some changes since the VP nodes were basically forked from them. I am not familiar with the indexing in masked load, for example. Maybe some of the RISC-V V folks can chime in whether any of the recent masked-sdnode updates should be applied to the vp nodes too.



================
Comment at: llvm/include/llvm/CodeGen/SelectionDAGNodes.h:2372
+  }
+  bool isExpandingLoad() const { return LoadSDNodeBits.IsExpanding; }
+};
----------------
Since expansion/compression is unsupported I don't think we need the `is.*Load/Store` functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105871/new/

https://reviews.llvm.org/D105871