[PATCH] D105879: Refine logic of MaskedElementsAreZero

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 13 01:57:23 PDT 2021


xiangzhangllvm added a comment.

Hello @RKSimon , I add you here, just because I git blamed that the code is your contribution.

Here I want to discuss with you about the logic of MaskedElementsAreZero first before I change and add related tests.

We want to Masked Elements (of vector) Are Zero, so the Mask pass to MaskedValueIsZero (in your old code) should be A Mask of vector.
Not clear why it just "APInt::getAllOnesValue(Op.getScalarValueSizeInBits())"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105879/new/

https://reviews.llvm.org/D105879



More information about the llvm-commits mailing list