[PATCH] D105742: [AMDGPU] Make V_CVT_I32_F64/V_CVT_F64_I32 rematerializable.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:125
   default:
+    if (isVOP1(MI) || isVOP3(MI))
+      return !MI.hasImplicitDef() &&
----------------
arsenm wrote:
> Braces
What about VOP2?


================
Comment at: llvm/test/CodeGen/AMDGPU/remat-vop.mir:340
     S_ENDPGM 0
 ...
----------------
Can you add a test with a mode def that blocks rematerialization?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105742/new/

https://reviews.llvm.org/D105742