[PATCH] D105742: [AMDGPU] Make V_CVT_I32_F64/V_CVT_F64_I32 rematerializable.
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 9 15:02:24 PDT 2021
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:125
default:
+ if (isVOP1(MI) || isVOP3(MI))
+ return !MI.hasImplicitDef() &&
----------------
Braces
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:129
+
return false;
}
----------------
Probably should get a comment about how normally exec would block rematerialization but should be OK, plus mode
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105742/new/
https://reviews.llvm.org/D105742
More information about the llvm-commits
mailing list