[PATCH] D105786: [lld-macho][nfc] Avoid using std::map for PlatformKinds

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 11 14:45:00 PDT 2021


thakis accepted this revision.
thakis added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/MachO/Driver.cpp:854
-  static const std::map<PlatformKind, VersionTuple> minVersion = {
+  static const std::vector<std::pair<PlatformKind, VersionTuple>> minVersion = {
       {PlatformKind::macOS, VersionTuple(10, 15)},
       {PlatformKind::iOS, VersionTuple(13, 0)},
----------------
I agree that a switch seems like the obvious fit here, but *shrug*


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105786/new/

https://reviews.llvm.org/D105786



More information about the llvm-commits mailing list