[PATCH] D105786: [lld-macho][nfc] Avoid using std::map for PlatformKinds

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 11 14:15:09 PDT 2021


int3 added a comment.

> In the removeSimulator case, I would expect it to be shorter and more readable.

I prefer to keep to the same code pattern as the other two PlatformKind mappings.

> And why is removeSimulator not somewhere in llvm Binaryformat?

That file doesn't seem to have a whole lot of helper functions, just struct definitions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105786/new/

https://reviews.llvm.org/D105786



More information about the llvm-commits mailing list