[PATCH] D105364: [lld-macho] Drop assertions that all symbols are in GOT

Fri Jul 9 15:49:26 PDT 2021

int3 added a comment.

> and the simplest test case. I could come up with was still using TWO inputs

This was really surprising to me so I dug into it. Turns out it's a regression from D105557: [lld/mac] Don't crash when dead-stripping removes all unwind info <https://reviews.llvm.org/D105557> (cc @thakis)

D105750: [not for review][lld-macho] Set allEntriesAreOmitted correctly for unwind info from ld -r <https://reviews.llvm.org/D105750> should fix things so that we can test this with just one file. Wanna fold the contents of D105750 <https://reviews.llvm.org/D105750> into this diff? We can't test that diff anyway without removing the `isInGot()` assert.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105364/new/

https://reviews.llvm.org/D105364