[PATCH] D105364: [lld-macho] Drop assertions that all symbols are in GOT

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 8 22:20:09 PDT 2021


oontvoo updated this revision to Diff 357418.
oontvoo added a comment.

In D105364#2866214 <https://reviews.llvm.org/D105364#2866214>, @int3 wrote:

> Q: what do the C files test that my small assembly test case doesn't cover?

Not much - I'd just forgot to simplify the yaml - I've regenerated the yaml files from your small assembly test and updated the test. PTAL
(but after D104502 <https://reviews.llvm.org/D104502>, the code path changed a bit - and the simplest test case. I could come up with was still  using TWO inputs)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105364/new/

https://reviews.llvm.org/D105364

Files:
  lld/MachO/UnwindInfoSection.cpp
  lld/test/MachO/relocs-syms-not-in-got.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105364.357418.patch
Type: text/x-patch
Size: 6037 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210709/8de25df8/attachment.bin>


More information about the llvm-commits mailing list