[PATCH] D105517: [AMDGPU] isPassEnabled() helper to check cl::opt and OptLevel

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:790
+  bool isPassEnabled(const cl::opt<bool> &Opt,
+                     CodeGenOpt::Level Level = CodeGenOpt::Default) const {
+    if (Opt.getNumOccurrences())
----------------
arsenm wrote:
> Don't see the point of the parameter if it's never used
I want to clean -O0 pipeline some more, so I will pass CodeGenOpt::Less there. Right now all such checks are done to distinguish between -O1 and -O2/-O3, so it is unused for a moment.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:967
-          ? EnableScalarIRPasses
-          : TM.getOptLevel() > CodeGenOpt::Less)
     addEarlyCSEOrGVNPass();
----------------
arsenm wrote:
> Not passing CodeGenOpt::Less?
Nope, default is CodeGenOpt::Default, which means >= Default, same as > Less.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105517/new/

https://reviews.llvm.org/D105517