[PATCH] D105517: [AMDGPU] isPassEnabled() helper to check cl::opt and OptLevel

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:789
+
+  bool isPassEnabled(const cl::opt<bool> &Opt,
+                     CodeGenOpt::Level Level = CodeGenOpt::Default) const {
----------------
Should add a documentation comment


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:790
+  bool isPassEnabled(const cl::opt<bool> &Opt,
+                     CodeGenOpt::Level Level = CodeGenOpt::Default) const {
+    if (Opt.getNumOccurrences())
----------------
Don't see the point of the parameter if it's never used


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:967
-          ? EnableScalarIRPasses
-          : TM.getOptLevel() > CodeGenOpt::Less)
     addEarlyCSEOrGVNPass();
----------------
Not passing CodeGenOpt::Less?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105517/new/

https://reviews.llvm.org/D105517