[PATCH] D105714: WIP/RFC: Generic MachineInstr convenience wrappers.

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/GenericInstWrapper.h:42
+  /// Get the definition register of the loaded value.
+  Register getLoadReg() const { return Inst->getOperand(0).getReg(); }
+  /// Get the source register of the pointer value.
----------------
paquette wrote:
> I feel like "load reg" isn't really descriptive.
> 
> Maybe `getDstReg()` would be better? That would also make it easy to share terminology with other wrappers.
Yeah, this is just a proposal, the specific names we could work out later (if we decide to do ahead at all).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105714/new/

https://reviews.llvm.org/D105714