[PATCH] D105571: [AArch64][SME] Add outer product instructions

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/test/MC/AArch64/SME/bfmopa-diagnostics.s:6
+
+bfmopa za4.s, p0/m, p0/m, z0.h, z0.h
+// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: invalid operand for instruction
----------------
Is it worth having a diagnostic case where the register suffix isn't right, i.e.

  bfmopa za4.s, p0/m, p0/m, z0.h, z0.d

?


================
Comment at: llvm/test/MC/AArch64/SME/fmopa-diagnostics.s:15
+
+fmopa za8.d, p0/m, p0/m, z0.d, z0.d
+// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: invalid operand for instruction
----------------
Again, might be useful to test an incorrect size suffix for the one of the registers?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105571/new/

https://reviews.llvm.org/D105571