[PATCH] D105572: [AArch64][SME] Add load and store instructions

[Caroline via Phabricator via llvm-commits]

CarolineConcatto added a comment.

Maybe you should add dependency of this patch with D105570 <https://reviews.llvm.org/D105570> in the commit message .
The operand needed for Za horizontal and vertical are added there.



================
Comment at: llvm/lib/Target/AArch64/SMEInstrFormats.td:360
+    bits<3> imm;
+    let Inst{3}  = ZAt;
+    let Inst{2-0} = imm;
----------------
nit: align


================
Comment at: llvm/test/MC/AArch64/SME/st1w-diagnostics.s:2
+// RUN: not llvm-mc -triple=aarch64 -show-encoding -mattr=+sme 2>&1 < %s| FileCheck %s
+
+// ------------------------------------------------------------------------- //
----------------
Is it  possible to create a diagnostic test for Match_InvalidMatrixTileVectorH or Match_InvalidMatrixTileVectorV?
They are added in D105570, but I don't see it being used here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105572/new/

https://reviews.llvm.org/D105572