[PATCH] D105539: [llvm-objdump][WebAssembly] Fix llvm-objdump on files without symbols

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

There's an awful lot of WebAssembly test failures in pre-merge. Are they related (they might not be)?



================
Comment at: llvm/test/tools/llvm-objdump/wasm/executable-without-symbols.test:1
+RUN: llvm-objdump -d %p/Inputs/main.wasm | FileCheck %s
+
----------------
sbc100 wrote:
> If we can we should try to find a way to avoid checking in the binary here.
> 
> Also, it would be good to have a test for a file that also lacks a name sections, in which case I would expect to see either empty names, or synthetic/fake names (which do you think make the most sense).
Would yaml2obj allow you to avoid the canned binary? Alternatively, presumably there's some way of building this from assembly?


================
Comment at: llvm/test/tools/llvm-objdump/wasm/executable-without-symbols.test:3
+
+CHECK:      Disassembly of section CODE:
+
----------------
Nit: not looked at wasm tests, but in most other llvm-objdump tests, we usually add comment markers (i.e. '#') for CHECK and RUN lines, even if they're not strictly necessary.

May be moot if you switch to yaml2obj or similar, as you'll need them anyway in that case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105539/new/

https://reviews.llvm.org/D105539