[PATCH] D105113: [LV] NFCI: Do cost comparison on InstructionCost directly.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 7 02:16:54 PDT 2021


dmgreen added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:6592
   SmallVector<RegisterUsage, 8> RUs(VFs.size());
   SmallVector<SmallMapVector<unsigned, unsigned, 4>, 8> MaxUsages(VFs.size());
 
----------------
These still use unsigned. Are we happy to assume that getRegUsageForType / getTypeLegalizationCost will always produce a small, sensible value?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105113/new/

https://reviews.llvm.org/D105113



More information about the llvm-commits mailing list