[PATCH] D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable.
Esme Yi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 7 21:41:37 PDT 2021
Esme added inline comments.
================
Comment at: llvm/tools/llvm-readobj/ObjDumper.cpp:68
}
W.startLine() << format("[%6tx] ", CurrentWord - StrContent);
printAsPrintable(W.startLine(), CurrentWord, WordSize);
----------------
shchenz wrote:
> The output is shown as hexadecimal data, but there is no "0x" prefix for the data, we should add the prefix or use decimal data?
Changing the output format will affect many tests on dumping sections. That is out of the scope of this patch. We can post another patch for it if necessary.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105522/new/
https://reviews.llvm.org/D105522
More information about the llvm-commits
mailing list