[PATCH] D105271: [PowerPC][ELF]make sure local variable space does not overlap with parameter save area

[ChenZheng via Phabricator via llvm-commits]

shchenz added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6019
+    } else if (Flags.isByVal() && Flags.getByValSize() >= 8)
+      HasParameterArea = true;
 
----------------
jsji wrote:
> This doesn't look like a correct fix to me.
> I think we rely on `CalculateStackSlotUsed` for non FastCall ELFV2ABI.
> Do we know why `CalculateStackSlotUsed`  is returning false for this case?
Thanks, I will do more investigation. Actually, I find the stack size is unnecessary bigger than needed after the fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105271/new/

https://reviews.llvm.org/D105271