[PATCH] D105271: [PowerPC][ELF]make sure local variable space does not overlap with parameter save area

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 7 09:21:06 PDT 2021


jsji added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6019
+    } else if (Flags.isByVal() && Flags.getByValSize() >= 8)
+      HasParameterArea = true;
 
----------------
This doesn't look like a correct fix to me.
I think we rely on `CalculateStackSlotUsed` for non FastCall ELFV2ABI.
Do we know why `CalculateStackSlotUsed`  is returning false for this case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105271/new/

https://reviews.llvm.org/D105271



More information about the llvm-commits mailing list