[PATCH] D105525: [GISel] Add fpext/fptrunc combines

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 7 15:35:40 PDT 2021


paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:1678
+  // `buildFConstant` will assert on size mismatch. Only `G_FPTRUNC`, `G_FPEXT`,
+  // `G_FSQRT`, and `G_FLOG2` reach here.
   bool Unused;
----------------
I think that we should have an assert that we get one of the expected opcodes here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105525/new/

https://reviews.llvm.org/D105525



More information about the llvm-commits mailing list