[PATCH] D105525: [GISel] Add fpext/fptrunc combines

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:2506
+
+bool CombinerHelper::applyCombineFPExtIntToFloat(
+    MachineInstr &MI, std::tuple<Register, unsigned> &MatchInfo) {
----------------
The apply functions here are basically identical. To reduce duplication, I think it would be better to either

a) Make a helper which handles this type of combine
b) Use `applyBuildFn`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105525/new/

https://reviews.llvm.org/D105525