[PATCH] D104142: [IROutliner] Ensure instructions at end of candidate are excluded

[Andrew Litteken via Phabricator via llvm-commits]

AndrewLitteken added inline comments.


================
Comment at: llvm/test/Transforms/IROutliner/outlining-bitcasts.ll:40
 define void @outline_bitcast_removed() {
-; CHECK-LABEL: @outline_bitcast_removed(
-; CHECK-NEXT:  entry:
----------------
paquette wrote:
> Why did these lines disappear?
They move down to the bottom of the test, I think this was a function of the test generation script.


================
Comment at: llvm/test/Transforms/IROutliner/outlining-bitcasts.ll:53
+; endpoint does not match the new endpoint, we cannot extract and outline the
+; second bitcast and set of ads.  Outlining only occurs in this case due to
+; the lack of a cost model
----------------
paquette wrote:
> paquette wrote:
> > 
> Sounds like "Outlining only occurs in this case due to the lack of a cost model" should be a FIXME?
It's not really a fix me, the no cost command line argument is here to test these sorts of cases, so that it's not dependent on the way that the cost of outlining is calculated, rather how we define similarity.  I can make this more clear.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104142/new/

https://reviews.llvm.org/D104142