[PATCH] D104142: [IROutliner] Ensure instructions at end of candidate are excluded

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:132
 
+  if (Candidate->end()->Inst !=
+      Candidate->backInstruction()->getNextNonDebugInstruction())
----------------
Move EndInst above and use it here?

Also, this could use a comment.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:1661
       OS->splitCandidate();
+      if (!OS->CandidateSplit)
+        continue;
----------------
Could use a comment explaining why this wouldn't happen.


================
Comment at: llvm/test/Transforms/IROutliner/outlining-bitcasts.ll:40
 define void @outline_bitcast_removed() {
-; CHECK-LABEL: @outline_bitcast_removed(
-; CHECK-NEXT:  entry:
----------------
Why did these lines disappear?


================
Comment at: llvm/test/Transforms/IROutliner/outlining-bitcasts.ll:53
+; endpoint does not match the new endpoint, we cannot extract and outline the
+; second bitcast and set of ads.  Outlining only occurs in this case due to
+; the lack of a cost model
----------------



================
Comment at: llvm/test/Transforms/IROutliner/outlining-bitcasts.ll:53
+; endpoint does not match the new endpoint, we cannot extract and outline the
+; second bitcast and set of ads.  Outlining only occurs in this case due to
+; the lack of a cost model
----------------
paquette wrote:
> 
Sounds like "Outlining only occurs in this case due to the lack of a cost model" should be a FIXME?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104142/new/

https://reviews.llvm.org/D104142