[PATCH] D104471: [llvm][sve] Lowering for VLS truncating stores

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:18071
+      TLI.isTruncStoreLegalOrCustom(Value.getOperand(0).getValueType(),
+                                    ST->getMemoryVT())) {
     return DAG.getTruncStore(Chain, SDLoc(N), Value.getOperand(0),
----------------
There's a potential infinite loop here: if a truncstore is "custom", and expands to trunc+store, combining never ends.  You can avoid this by checking for LegalOperations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104471/new/

https://reviews.llvm.org/D104471