[PATCH] D103955: [MCA] Use LSU for the in-order pipeline

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 1 03:21:44 PDT 2021


andreadb added inline comments.


================
Comment at: llvm/test/tools/llvm-mca/AArch64/Cortex/A55-load-store-noalias.s:95-96
+
+# CHECK:      [0,0]     DeeeE.    ..   str	x1, [x10]
+# CHECK-NEXT: [0,1]     .DeeeE    ..   str	x1, [x10]
+# CHECK-NEXT: [0,2]     .DeeE.    ..   ldr	x2, [x10]
----------------
andreadb wrote:
> dmgreen wrote:
> > I think I would expect most CPU's to work like this, whether the addresses alias or not :)
> You mean the store sequence. Of course.
> 
> My concern was related to instructions that appear to commit out of order like the load and the nop after it.
> We have flag RetireOOO for cases where we want to allow it.
If instead you are concerned about whether this patch might end up delaying the second store, then don't worry. That's not how flag -noalias should work: it only affects interactions between loads and stores. It is about whether a younger load is allowed to pass an older store. It should not affect pairs of adjacent stores.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103955/new/

https://reviews.llvm.org/D103955



More information about the llvm-commits mailing list