[PATCH] D105055: [llvm-readobj] Make -s and -t match llvm-readelf

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 1 00:26:56 PDT 2021


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/merged.test:55
 ## were supported.
-# RUN: not llvm-readobj -aeWhSrnudlVgIs %t.o 2>&1 | FileCheck %s --check-prefix=UNKNOWN
+# RUN: not llvm-readobj -aeWhSsrnudlVgIS %t.o 2>&1 | FileCheck %s --check-prefix=UNKNOWN
 
----------------
MaskRay wrote:
> jhenderson wrote:
> > You've still got `S` twice in this list (at the end and immediately after the `h`).
> Previously both `-S` and `-s` were aliases for `--section-headers`. That was how the diagnostic was triggered.
> 
> Keeping two `-S` can trigger the `--section-headers`. If I drop one the message will go away.
Oh, sorry, misread what the test was doing, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105055/new/

https://reviews.llvm.org/D105055



More information about the llvm-commits mailing list