[PATCH] D105055: [llvm-readobj] Make -s and -t match llvm-readelf

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/merged.test:55
 ## were supported.
-# RUN: not llvm-readobj -aeWhSrnudlVgIs %t.o 2>&1 | FileCheck %s --check-prefix=UNKNOWN
+# RUN: not llvm-readobj -aeWhSsrnudlVgIS %t.o 2>&1 | FileCheck %s --check-prefix=UNKNOWN
 
----------------
jhenderson wrote:
> You've still got `S` twice in this list (at the end and immediately after the `h`).
Previously both `-S` and `-s` were aliases for `--section-headers`. That was how the diagnostic was triggered.

Keeping two `-S` can trigger the `--section-headers`. If I drop one the message will go away.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/merged.test:55
 ## were supported.
-# RUN: not llvm-readobj -aeWhSrnudlVgIs %t.o 2>&1 | FileCheck %s --check-prefix=UNKNOWN
+# RUN: not llvm-readobj -aeWhSrnudlVgIS %t.o 2>&1 | FileCheck %s --check-prefix=UNKNOWN
 
----------------
jhenderson wrote:
> No need to change this test, I think. You still want `-s` in the list, and you already have `-S` there. You might also want to add `-t`, but it's not really importantn, in my opinion.
The diagnostic is because `--section-headers` is specified twice. We need two `-S` to trigger the previous diagnostic. I'll keep one `-s` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105055/new/

https://reviews.llvm.org/D105055