[PATCH] D105198: [WIP][llvm][Inline] Add helper function for inliner

[Kazu Hirata via Phabricator via llvm-commits]

kazu added a comment.

In D105198#2850223 <https://reviews.llvm.org/D105198#2850223>, @mtrofin wrote:

> Can you detail a bit what motivates the change - do you plan to expose and reuse the code elsewhere? That would help in 2 ways:
>
> - understanding how to review
> - avoiding names like 'helper' in descriptions (or - not the case here - APIs). 'helper', like 'utility', communicates very little (it's not like an API would be otherwise called 'unhelpful')

I think Liqiang is trying to factor out the bit `while` loop so that we can share it between the module inliner and the SCC inliner, but sure, he can clarify things both in the commit message and the source code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105198/new/

https://reviews.llvm.org/D105198