[PATCH] D105198: [WIP][llvm][Inline] Add helper function for inliner

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

Can you detail a bit what motivates the change - do you plan to expose and reuse the code elsewhere? That would help in 2 ways:

- understanding how to review
- avoiding names like 'helper' in descriptions (or - not the case here - APIs). 'helper', like 'utility', communicates very little (it's not like an API would be otherwise called 'unhelpful')



================
Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:811
+static bool
+doInline(std::unique_ptr<InlineOrder<std::pair<CallBase *, int>>> &Calls,
+         InlineAdvisor &Advisor, ProfileSummaryInfo *PSI,
----------------
should this be a member function instead - to avoid passing so many parameters?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105198/new/

https://reviews.llvm.org/D105198