[PATCH] D104509: [RegisterCoalescer] Resolve conflict based on liveness of subregister

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 29 11:09:21 PDT 2021


arsenm added a comment.

LGTM with typo / indentation fixed



================
Comment at: llvm/lib/CodeGen/RegisterCoalescer.cpp:2859
+    auto &OtherLI = LIS->getInterval(Other.Reg);
+    // If OtherVNI does not has subranges, it means all the lanes of OtherVNI
+    // share the same live range, so we just need to check whether they have
----------------
Grammar, s/has/have/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104509/new/

https://reviews.llvm.org/D104509



More information about the llvm-commits mailing list