[PATCH] D104509: [RegisterCoalescer] Resolve conflict based on liveness of subregister

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Looks fine to me but please wait on the comment from Jay (@foad ) and Matt (@arsenm ) before pushing.
Nitpick below.



================
Comment at: llvm/lib/CodeGen/RegisterCoalescer.cpp:2885
+    return CR_Replace;
+  } else {
+    // We need to verify that no instructions are reading the clobbered lanes.
----------------
No else after return. This would also avoid the increased indentation here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104509/new/

https://reviews.llvm.org/D104509