[PATCH] D105033: [TableGen] Allow identical MnemonicAliases with no predicate

[Nicolas Guillemot via Phabricator via llvm-commits]

nlguillemot added a comment.

In the code sample in the description, is it supposed to be `Feature_Subtarget2Bit` for the second "if"?

One thing I'm wondering is, how about defining the MnemonicAlias just once outside the multiclass? Like this:

  defm FooInst1 : DefInstruction<"foo", (outs), (ins), Subtarget1>;
  defm FooInst2 : DefInstruction<"foo", (outs), (ins), Subtarget2>;
  def : MnemonicAlias<"foo_alias", "foo">;

Otherwise if the MnemonicAlias is in the multiclass then there are two virtually identical MnemonicAliases being defined right?

I think that generally speaking it makes sense to avoid letting users use duplicate inputs since that might help catch errors in some cases. On the other hand I can see the practical utility in allowing duplicates when it comes to working with multiclasses. I'm not sure, thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105033/new/

https://reviews.llvm.org/D105033