[PATCH] D105023: [NFC][AIX][XCOFF][Bug-Fixed] parse the parameter type of the traceback table.
Jason Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 28 08:24:31 PDT 2021
jasonliu added inline comments.
================
Comment at: llvm/lib/BinaryFormat/XCOFF.cpp:146
- if (Value != 0u || ParsedFixedNum > FixedParmsNum ||
- ParsedFloatingNum > FloatingParmsNum)
+ if (Value != 0u)
return createStringError(errc::invalid_argument,
----------------
Relay offline discussion:
The underlying issue with the current approach is that `FixedParmsNum` and `FloatingParmsNum` passed in are the real parameters number of those types that we get, but the number of them could be more than what `Value` could encode.
I don't think the current solution in this patch addressed that underlying issue.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105023/new/
https://reviews.llvm.org/D105023
More information about the llvm-commits
mailing list