[PATCH] D105023: [NFC][AIX][XCOFF][Bug-Fixed] parse the parameter type of the traceback table.

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 28 06:54:49 PDT 2021


jasonliu added inline comments.


================
Comment at: llvm/lib/BinaryFormat/XCOFF.cpp:147
-  if (Value != 0u || ParsedFixedNum > FixedParmsNum ||
-      ParsedFloatingNum > FloatingParmsNum)
     return createStringError(errc::invalid_argument,
----------------
IIUC, this is not a NFC, and we are changing the behavior in a user visible way. So we need to add a test case for this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105023/new/

https://reviews.llvm.org/D105023



More information about the llvm-commits mailing list