[PATCH] D104229: [flang][docs] Add documentation for the new Flang driver

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski marked an inline comment as done.
awarzynski added inline comments.


================
Comment at: flang/docs/FlangDriver.md:139
+
+The are many predefined TableGen classes and records that you can use to fine
+tune your new option. The list of available configurations can be overwhelming
----------------
naromero77 wrote:
> Grammar... `There are ..."
Thank you, fixed!


================
Comment at: flang/docs/FlangDriver.md:69
+```
+flang -ccc-print-phases -c file.f
+         +- 0: input, "file.f", f95-cpp-input
----------------
richard.barton.arm wrote:
> I thought this was wrong when I first saw it, but I can reproduce. What's flang-new doing here then? I thought there was no support for these phases in flang yet?
Sorry, I should've clarified.

`-ccc-print-phases` prints what phases `clangDriver` _would_ generate. That's not something `flang-new` is in control of. However, when you try to run it without `-ccc-print-phases`, it fails during the 2nd phase above:
```
error: code-generation is not available yet
```

Making `-ccc-print-phases` a bit more clever would be nice, but it would have to happen in Clang. In the meantime, I will add a clarification here.


================
Comment at: flang/docs/FlangDriver.md:156
+can implement this in `clang/lib/Driver/ToolChains/Flang.cpp`. Plain command
+line option forwarding for Flang is tested in
+`flang/test/Driver/frontend-forward.F90`.
----------------
arnamoy10 wrote:
> May want to elaborate what you mean by "Plain command line option", or reword
I will reword this section a bit, thanks!


================
Comment at: flang/docs/FlangDriver.md:184
+be exactly what you want to test.  In fact, you can check these additional
+flags by using the `-###` compiler driver command line option.
----------------
arnamoy10 wrote:
> Not sure if we want to document the use of `!REQUIRES` here
That's a good suggestion, though I will avoid `! REQUIRES: new-flang-driver`, as we want to get rid of it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104229/new/

https://reviews.llvm.org/D104229