[PATCH] D104542: [M68k][GloballSel] Formal arguments lowering in IRTranslator

Sushma Unnibhavi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 26 03:26:19 PDT 2021


sushmaunnibhavi added a comment.

In D104542#2840195 <https://reviews.llvm.org/D104542#2840195>, @myhsu wrote:

> I'm curious if the test pass on your side. When I applied this patch on tip-of-tree, the newly-added test case triggered unreachable statement on line 87 of `lib/Target/M68k/GlSel/M68kCallLowering.cpp` (i.e. `M68kIncomingValueHandler::getStackAddress` was called).
> Can you double check if this patch works on tip-of-tree? (of course please make sure you have assertion enabled in your build)

I did build my patch again but I don't get any errors.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104542/new/

https://reviews.llvm.org/D104542



More information about the llvm-commits mailing list