[PATCH] D104542: [M68k][GloballSel] Formal arguments lowering in IRTranslator

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added a comment.

I'm curious if the test pass on your side. When I applied this patch on tip-of-tree, the newly-added test case triggered unreachable statement on line 87 of `lib/Target/M68k/GlSel/M68kCallLowering.cpp` (i.e. `M68kIncomingValueHandler::getStackAddress` was called).
Can you double check if this patch works on tip-of-tree? (of course please make sure you have assertion enabled in your build)



================
Comment at: llvm/lib/Target/M68k/GlSel/M68kCallLowering.h:68
+
+public:
+  FormalArgHandler(MachineIRBuilder &MIRBuilder, MachineRegisterInfo &MRI)
----------------
please use struct instead and remove "public" in this line as well as the empty line above


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104542/new/

https://reviews.llvm.org/D104542