[PATCH] D104938: OpaquePtr: Reject 'ptr*' again when parsing textual IR

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG4506f614cb69: OpaquePtr: Reject 'ptr*' again when parsing textual IR (authored by dexonsmith).

Changed prior to commit:
  https://reviews.llvm.org/D104938?vs=354567&id=354616#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104938/new/

https://reviews.llvm.org/D104938

Files:
  llvm/lib/AsmParser/LLParser.cpp
  llvm/test/Assembler/invalid-opaque-ptr-addrspace.ll
  llvm/test/Assembler/invalid-opaque-ptr.ll


Index: llvm/test/Assembler/invalid-opaque-ptr.ll
===================================================================
--- /dev/null
+++ llvm/test/Assembler/invalid-opaque-ptr.ll
@@ -0,0 +1,7 @@
+; RUN: not llvm-as < %s -disable-output 2>&1 | FileCheck %s
+
+; CHECK: ptr* is invalid - use ptr instead
+define void @f(ptr %a) {
+    %b = bitcast ptr %a to ptr*
+    ret void
+}
Index: llvm/test/Assembler/invalid-opaque-ptr-addrspace.ll
===================================================================
--- /dev/null
+++ llvm/test/Assembler/invalid-opaque-ptr-addrspace.ll
@@ -0,0 +1,7 @@
+; RUN: not llvm-as < %s -disable-output 2>&1 | FileCheck %s
+
+; CHECK: ptr* is invalid - use ptr instead
+define void @f(ptr addrspace(3) %a) {
+    %b = bitcast ptr addrspace(3) %a to ptr addrspace(3)*
+    ret void
+}
Index: llvm/lib/AsmParser/LLParser.cpp
===================================================================
--- llvm/lib/AsmParser/LLParser.cpp
+++ llvm/lib/AsmParser/LLParser.cpp
@@ -2597,6 +2597,8 @@
         return tokError("basic block pointers are invalid");
       if (Result->isVoidTy())
         return tokError("pointers to void are invalid - use i8* instead");
+      if (Result->isOpaquePointerTy())
+        return tokError("ptr* is invalid - use ptr instead");
       if (!PointerType::isValidElementType(Result))
         return tokError("pointer to this type is invalid");
       Result = PointerType::getUnqual(Result);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104938.354616.patch
Type: text/x-patch
Size: 1446 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210625/2694cfbb/attachment.bin>